Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Reset button by Apply in the yaxis strategy selector #832 #833

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

ElderOrb
Copy link
Collaborator

@ElderOrb ElderOrb commented Jul 9, 2024

No description provided.

@dericed
Copy link
Member

dericed commented Jul 11, 2024

image

So if I change >1 yaxis strategy and select to reset all, then I get a message that only references the first change.

@dericed
Copy link
Member

dericed commented Jul 11, 2024

Can you also add a per-graph reset on the modal yaxis popup?

@ElderOrb
Copy link
Collaborator Author

image

So if I change >1 yaxis strategy and select to reset all, then I get a message that only references the first change.

The message was meant to say 'all the Y axis are going to b reset'. Can you provide better one?

@dericed
Copy link
Member

dericed commented Jul 11, 2024

Oh i think I read too fast and thought it meant the Y as in luma channel graph. How about "Y-axis" instead of "Y axis".

@ElderOrb
Copy link
Collaborator Author

Oh i think I read too fast and thought it meant the Y as in luma channel graph. How about "Y-axis" instead of "Y axis".

Maybe 'All Y-axis' to make it more explicit?

@dericed
Copy link
Member

dericed commented Jul 11, 2024

great. will merge pending CI

@dericed dericed merged commit 0edd5ed into bavc:main Jul 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants